-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 5576 - first step towards multi product types #5593
Merged
monsieurtanuki
merged 6 commits into
openfoodfacts:develop
from
monsieurtanuki:fix/5576
Sep 25, 2024
Merged
fix: 5576 - first step towards multi product types #5593
monsieurtanuki
merged 6 commits into
openfoodfacts:develop
from
monsieurtanuki:fix/5576
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `add_basic_details_page.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `background_task.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `background_task_download_products.dart`: saved new field `Product.productType` * `dao_product.dart`: now we're storing the `Product.productType` field * `edit_new_packagings.dart`: now using new field `Product.productType` * `edit_new_packagings_component.dart`: now using new field `Product.productType` * `edit_product_page.dart`: specific icon for "food" categories; no nutrition for "beauty" and "product" * `forgot_password_page.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `lazy_counter.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `login_result.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `newsfeed_provider.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `ocr_ingredients_helper.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `ocr_packaging_helper.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `onboarding_data_product.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `ordered_nutrients_cache.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `paged_product_query.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `product_cards_helper.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `product_image_crop_button.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `product_image_gallery_other_view.dart`: now using new field `Product.productType` * `product_image_other_page.dart`: now using new field `Product.productType` * `product_image_server_button.dart`: now using new field `Product.productType` * `product_image_widget.dart`: now using new field `Product.productType` * `product_list_page.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `product_query.dart`: now when we look for a barcode (or refresh a product), we use all productTypes if needed * `product_refresher.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded `openfoodfacts` to `3.15.0` for new `Product.productType` field * `sign_up_page.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `simple_input_page_helpers.dart`: new class dedicated to non-food categories * `simple_input_text_field.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `simple_input_widget.dart`: now using new field `Product.productType` * `temp_product_list_share_helper.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper` * `uploaded_image_gallery.dart`: now using new field `Product.productType` * `user_preferences_dev_debug_info.dart`: replaced getter `ProductQuery.uriProductHelper` with method `ProductQuery.getUriProductHelper`
github-actions
bot
added
🥫 Product page
👥 User management
Account login, signup, signout
dependencies
🖼️ Photos - Cropping
✏️ Editing - Basic info input
User lists
✏️ Editing - 📦 Packaging input
OCR page
labels
Sep 18, 2024
g123k
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a first step, it seems OK for me 👍
Thank you @g123k for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
✏️ Editing - Basic info input
✏️ Editing - 📦 Packaging input
OCR page
🖼️ Photos - Cropping
🥫 Product page
User lists
👥 User management
Account login, signup, signout
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
Fixes bug(s)
Part of
Impacted files
add_basic_details_page.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
background_task.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
background_task_download_products.dart
: saved new fieldProduct.productType
dao_product.dart
: now we're storing theProduct.productType
fieldedit_new_packagings.dart
: now using new fieldProduct.productType
edit_new_packagings_component.dart
: now using new fieldProduct.productType
edit_product_page.dart
: specific icon for "food" categories; no nutrition for "beauty" and "product"forgot_password_page.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
lazy_counter.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
login_result.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
newsfeed_provider.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
ocr_ingredients_helper.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
ocr_packaging_helper.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
onboarding_data_product.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
ordered_nutrients_cache.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
paged_product_query.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
product_cards_helper.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
product_image_crop_button.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
product_image_gallery_other_view.dart
: now using new fieldProduct.productType
product_image_other_page.dart
: now using new fieldProduct.productType
product_image_server_button.dart
: now using new fieldProduct.productType
product_image_widget.dart
: now using new fieldProduct.productType
product_list_page.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
product_query.dart
: now when we look for a barcode (or refresh a product), we use all productTypes if neededproduct_refresher.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
pubspec.lock
: wtfpubspec.yaml
: upgradedopenfoodfacts
to3.15.0
for newProduct.productType
fieldsign_up_page.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
simple_input_page_helpers.dart
: new class dedicated to non-food categoriessimple_input_text_field.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
simple_input_widget.dart
: now using new fieldProduct.productType
temp_product_list_share_helper.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper
uploaded_image_gallery.dart
: now using new fieldProduct.productType
user_preferences_dev_debug_info.dart
: replaced getterProductQuery.uriProductHelper
with methodProductQuery.getUriProductHelper