-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5326 - add prices to proof from gallery (and thumbnails) #5670
feat: 5326 - add prices to proof from gallery (and thumbnails) #5670
Conversation
New files: * `background_task_add_other_price.dart`: Background task about adding prices to an existing proof. * `background_task_price.dart`: Abstract background task about adding prices. Impacted files: * `background_task_add_price.dart`: refactored using new class `BackgroundTaskPrice` * `get_prices_model.dart`: new web app root address * `operation_type.dart`: added the new background task * `osm_location.dart`: minor refactoring * `price_currency_selector.dart`: additional case - proof instead of input; refactored using model * `price_date_card.dart`: additional case - proof instead of input * `price_location_card.dart`: additional case - proof instead of input * `price_model.dart`: added specific constructor and background task for the "existing proof" case * `price_product_widget.dart`: minor refactoring * `price_proof_card.dart`: additional case - proof instead of input * `price_proof_page.dart`: added a FAB to add price from an existing proof; now displaying the thumbnail and then the full proof * `price_user_button.dart`: new web app root address * `prices_proofs_page.dart`: proof thumnails; new web app root address * `prices_users_page.dart`: new web app root address * `product_price_add_page.dart`: now accepting a model as parameter, in order to deal with both old proofs and new prices * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded to `openfoodfacts` `3.16.0`, for proof thumbnails * `user_preferences_account.dart`: new web app root address
Oops, detected a bug, working on it... |
Impacted files: * `osm_location.dart`: more flexibility with potentially null data * `price_model.dart`: more flexibility with potentially null data; better display of thumbnail image * `price_proof_page.dart`: more flexibility with potentially null data
The bug was about Prices sometimes sending incomplete proof data (e.g. the location field being "unexpectedly" TL;DR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you @teolemon for your review! |
What
Screenshots
Part of
Files
New files:
background_task_add_other_price.dart
: Background task about adding prices to an existing proof.background_task_price.dart
: Abstract background task about adding prices.Impacted files:
background_task_add_price.dart
: refactored using new classBackgroundTaskPrice
get_prices_model.dart
: new web app root addressoperation_type.dart
: added the new background taskosm_location.dart
: minor refactoringprice_currency_selector.dart
: additional case - proof instead of input; refactored using modelprice_date_card.dart
: additional case - proof instead of inputprice_location_card.dart
: additional case - proof instead of inputprice_model.dart
: added specific constructor and background task for the "existing proof" caseprice_product_widget.dart
: minor refactoringprice_proof_card.dart
: additional case - proof instead of inputprice_proof_page.dart
: added a FAB to add price from an existing proof; now displaying the thumbnail and then the full proofprice_user_button.dart
: new web app root addressprices_proofs_page.dart
: proof thumnails; new web app root addressprices_users_page.dart
: new web app root addressproduct_price_add_page.dart
: now accepting a model as parameter, in order to deal with both old proofs and new pricespubspec.lock
: wtfpubspec.yaml
: upgraded toopenfoodfacts
3.16.0
, for proof thumbnailsuser_preferences_account.dart
: new web app root address