Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5691 - fallback when "nulls last" not supported by db #5695

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • According to Sentry, some SQFlite implementations don't support "nulls last" in select queries.
  • It's not a key feature: when it's not supported, we retry with a simpler syntax.

Fixes bug(s)

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 6.79%. Comparing base (4d9c7fc) to head (53f8ab3).
Report is 360 commits behind head on develop.

Files with missing lines Patch % Lines
packages/smooth_app/lib/database/dao_product.dart 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5695      +/-   ##
==========================================
- Coverage     9.54%   6.79%   -2.75%     
==========================================
  Files          325     404      +79     
  Lines        16411   21559    +5148     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   20093    +5249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monsieurtanuki monsieurtanuki merged commit e9eba42 into openfoodfacts:develop Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants