Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Onboarding: add a slight padding for the Continue button #5705

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 18, 2024

Hi everyone,

On devices without a transparent nav bar (eg: iPhone SE), the "Continue" button has no padding:
Simulator Screenshot - iPhone SE (3rd generation) - 2024-10-18 at 14 00 59

That's a simple fix for that.

@g123k g123k added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Oct 18, 2024
@g123k g123k self-assigned this Oct 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.79%. Comparing base (4d9c7fc) to head (35d5db2).
Report is 377 commits behind head on develop.

Files with missing lines Patch % Lines
...b/pages/onboarding/v2/onboarding_bottom_hills.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5705      +/-   ##
==========================================
- Coverage     9.54%   6.79%   -2.76%     
==========================================
  Files          325     404      +79     
  Lines        16411   21584    +5173     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   20118    +5274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @g123k 👍

@teolemon teolemon merged commit bb1c105 into openfoodfacts:develop Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS - iPhone SE 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Development

Successfully merging this pull request may close these issues.

3 participants