-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5428 - page dedicated to prices #5730
Conversation
New file: * `prices_home_page.dart`: Home page of Prices Impacted file: * `user_preferences_account.dart`: replaced the whole prices items with a single item linking to new page `PricesHomePage`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5730 +/- ##
==========================================
- Coverage 9.54% 7.00% -2.55%
==========================================
Files 325 406 +81
Lines 16411 21648 +5237
==========================================
- Hits 1567 1516 -51
- Misses 14844 20132 +5288 ☔ View full report in Codecov by Sentry. |
@monsieurtanuki Can you move it up a level ? |
You mean, a "prices" button directly from the main "Mes préférences" page and not from "My account" page?
That would only mean moving the single "donation" button to the main page, right? |
yes & yes, that would be it |
New files: * `user_preferences_donation.dart`: Display of "Donation" for the preferences page. * `user_preferences_prices.dart`: Display of "Prices" for the preferences page. Deleted file: * `prices_home_page.dart` Impacted files: * `app_en.arb`: added a short label for "donation" * `user_preferences_account.dart`: removed link to `PricesHomePage` * `user_preferences_contribute.dart`: removed the "donation" item * `user_preferences_page.dart`: added "donation" and "prices" as preferences
@teolemon Done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @monsieurtanuki
What
Screenshots
Fixes bug(s)
Files
New file:
prices_home_page.dart
: Home page of PricesImpacted file:
user_preferences_account.dart
: replaced the whole prices items with a single item linking to new pagePricesHomePage