Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to Material 3 #5736

Merged
merged 2 commits into from
Oct 25, 2024
Merged

feat: Switch to Material 3 #5736

merged 2 commits into from
Oct 25, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 25, 2024

Hi everyone,

The POC uses Material 3, so let's switch to it.
The text is a bit darker now, but I think that's OK.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A material change

@teolemon
Copy link
Member

@g123k the Golden are broken
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Improving_Page_Light_Theme (failed)
✅ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/generic_lib/widgets/smooth_error_card_test.dart: SmoothErrorCard find error message
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Software development_Page_Light_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Translate_Page_Light_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Improving_Page_Dark_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Software development_Page_Dark_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Translate_Page_Dark_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Improving_Page_AMOLED_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Software development_Page_AMOLED_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/dialogs/generic_lib/dialogs_test.dart: Dialogs on Contribute Page looks as expected Translate_Page_AMOLED_Theme (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/user_preferences_page_test.dart: UserPreferencesPage looks as expected Light (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/user_preferences_page_test.dart: UserPreferencesPage looks as expected Dark (failed)
✅ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/widget_test.dart: Fake test
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/user_preferences_page_test.dart: UserPreferencesPage looks as expected AMOLED (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/users/forgot_password_page_layout_test.dart: Password Reset Page looks as expected Light (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/users/forgot_password_page_layout_test.dart: Password Reset Page looks as expected Dark (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/users/forgot_password_page_layout_test.dart: Password Reset Page looks as expected AMOLED (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/users/signup_page_layout_test.dart: LoginPage looks as expected Light (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/users/signup_page_layout_test.dart: LoginPage looks as expected Dark (failed)
❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/users/signup_page_layout_test.dart: LoginPage looks as expected AMOLED (failed)

@teolemon
Copy link
Member

thanks, it passes @g123k , merging

@teolemon teolemon merged commit 388e4d0 into develop Oct 25, 2024
9 checks passed
@teolemon teolemon deleted the material3 branch October 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants