feat: 5418 - Prices - "Are you sure you want to exit?" feature #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `price_add_product_card.dart`: now accessing amount items through specific methods * `price_amount_card.dart`: now accessing amount items through specific methods * `price_amount_model.dart`: new `hasChanged` getter * `price_model.dart`: new `hasChanged` getter; now giving access to amount items through specific methods * `price_proof_card.dart`: minor refactoring * `product_price_add_page.dart`: used `WillPopScore2` in order to check for changes against back gesture; now accessing amount items through specific methods * `user_preferences_prices.dart`: usage of `AppNavigator` for a better management of back gesture
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5737 +/- ##
==========================================
- Coverage 9.54% 6.98% -2.57%
==========================================
Files 325 406 +81
Lines 16411 21699 +5288
==========================================
- Hits 1567 1516 -51
- Misses 14844 20183 +5339 ☔ View full report in Codecov by Sentry. |
teolemon
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
WillPopScopeeffect ("you've changed data: are you sure you want to exit?") #5418Impacted files
price_add_product_card.dart: now accessing amount items through specific methodsprice_amount_card.dart: now accessing amount items through specific methodsprice_amount_model.dart: newhasChangedgetterprice_model.dart: newhasChangedgetter; now giving access to amount items through specific methodsprice_proof_card.dart: minor refactoringproduct_price_add_page.dart: usedWillPopScore2in order to check for changes against back gesture; now accessing amount items through specific methodsuser_preferences_prices.dart: usage ofAppNavigatorfor a better management of back gesture