bug/#616 - small layout fix for search panel #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `search_panel.dart`: added margin to title * `smooth_app/pubspec.yaml`: unrelated library upgrades * `smooth_ui_library/pubspec.yaml`: unrelated library upgrades
1 task
slava-sh
approved these changes
Oct 26, 2021
|
Thank you @slava-sh! For the record smaller titles are centered: And perhaps it would look better with the title aligned to the field hint instead of aligned to the RRect: If someone feels like fine-tuning the alignment, the margin in margin: const EdgeInsets.only(
left: LARGE_SPACE + 20,
right: LARGE_SPACE + 20,
bottom: SMALL_SPACE,
), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
search_panel.dart: added margin to titlesmooth_app/pubspec.yaml: unrelated library upgradessmooth_ui_library/pubspec.yaml: unrelated library upgradesThis is what it looks like in French:
This is what it looks like in debug phase:
