Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #678 - added bottom navigation bar to product page #679

Merged
merged 4 commits into from
Nov 25, 2021

Commits on Nov 22, 2021

  1. feat: openfoodfacts#678 - added bottom navigation bar to product page

    The previous bottom navigation bottom bar was refactored, in order to be reused anywhere.
    Then it was added to the product page.
    
    Deleted files:
    * `home_page.dart`
    * `smooth_ui_library/smooth_bottom_navigation_bar.dart`
    * `smooth_ui_library/smooth_bottom_navigation_bar_item.dart`
    
    New file:
    * `smooth_bottom_navigation_bar.dart`
    
    Impacted files:
    * `continuous_scan_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`)
    * `main.dart`: not using `HomePage` anymore; asking the bottom navigation bar who's the current page instead
    * `new_product_page.dart`: added an explicit bottom navigation bar (was not there)
    * `product_list_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`)
    * `product_page.dart`: added an explicit bottom navigation bar (was not there)
    * `smooth_ui_library.dart`: removed "UI" version of smooth bottom navigation bar
    * `user_preferences.dart`: added a preference for tab index
    * `user_preferences_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`)
    monsieurtanuki committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    30e6841 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. feat: openfoodfacts#678 - explicitly selecting the bottom navigation tab

    Impacted files:
    * `continuous_scan_page.dart`: explicitly select the "scan" tab
    * `new_product_page.dart`: implicitly select the "default" tab
    * `product_list_page.dart`: explicitly select the "history" tab
    * `product_page.dart`: implicitly select the "default" tab
    * `smooth_bottom_navigation_bar.dart`: now explicitly selecting the tab, instead of storing it in preferences
    * `user_preferences.dart`: removed tab index preference
    * `user_preferences_page.dart`: explicitly select the "profile" tab
    monsieurtanuki committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    683dc9a View commit details
    Browse the repository at this point in the history
  2. feat: openfoodfacts#678 - (forgot that one)

    Impacted file:
    * `main.dart`: implicitly select the "default" tab and the matching page
    monsieurtanuki committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    49b21a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Configuration menu
    Copy the full SHA
    5b51a2a View commit details
    Browse the repository at this point in the history