Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RACK_TIMEOUT_TERM_ON_TIMEOUT for fr-prod #934

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

rioug
Copy link
Contributor

@rioug rioug commented Aug 19, 2024

Part of openfoodfoundation/openfoodnetwork#12761

same as uk-prod #932, adding RACK_TIMEOUT_TERM_ON_TIMEOUT to mitigate issue with the db connection pool.

Rack timeout is causing issue with the db pool, where connection are
not release properly after a rack timout.
Adding RACK_TIMEOUT_TERM_ON_TIMEOUT can mitigate the issue as explained
in the docs : https://github.com/zombocom/rack-timeout/blob/master/doc/settings.md#term-on-timeout
@rioug rioug self-assigned this Aug 19, 2024
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're pretty confident that this resolves the issue.
In that case, shall we make this the default for all instances?

@mkllnk mkllnk merged commit 856cfe3 into openfoodfoundation:master Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants