Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-build branch from master to main #975

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 3, 2025

The HEAD branch was renamed. Even after updating the name in Ansible, it still failed on not wanting to override a tag. The workaround is to delete the plugin remotely:

rm ~/.nodenv/plugins/node-build/ -rf

I don't think it's worth integrating into Ansible. It would be better to switch to a bash script installing node.

The HEAD branch was renamed. Even after updating the name in Ansible, it
still failed on not wanting to override a tag. The workaround is to
delete the plugin remotely:

```
rm ~/.nodenv/plugins/node-build/ -rf
```

I don't think it's worth integrating into Ansible. It would be better to
switch to a bash script installing node.
@mkllnk mkllnk self-assigned this Jan 3, 2025
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

So I'm guessing this is to

And that we would also need to manually delete/reset the plugin on each server after it is merged?

@rioug
Copy link
Contributor

rioug commented Jan 5, 2025

I am a bit confused, are you saying this change doesn't fix the problem ? is it actually worth doing it ? I guess it makes sense for consistency, but if we are going to stop using it why not leaving it as it is till we move to a bash script ?

@mkllnk
Copy link
Member Author

mkllnk commented Jan 6, 2025

are you saying this change doesn't fix the problem ?

It does fix the problem but it also needs a once-off manual fix to sort out git.

@mkllnk
Copy link
Member Author

mkllnk commented Jan 6, 2025

we would also need to manually delete/reset the plugin on each server after it is merged?

Yes, I think so.

@mkllnk mkllnk merged commit 50a44cf into openfoodfoundation:master Jan 6, 2025
1 check passed
@mkllnk mkllnk deleted the node-build-branch branch January 6, 2025 23:44
@mkllnk
Copy link
Member Author

mkllnk commented Jan 6, 2025

I removed the outdated repositories:

ansible all_staging -u openfoodnetwork -a "rm ~/.nodenv/plugins/node-build/ -rf"
ansible all_prod -u openfoodnetwork -a "rm ~/.nodenv/plugins/node-build/ -rf"

Provisioning should restore that again. And we don't need it unless our node version changes.

@dacook
Copy link
Member

dacook commented Jan 7, 2025

Great, I love it when ansible helps solve little problems like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants