-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external billing id on enterprises #12980
base: master
Are you sure you want to change the base?
Add external billing id on enterprises #12980
Conversation
ccd284b
to
193be72
Compare
Oops, it seems I have some failing specs, working on it asap. |
LGTM! Many thanks @pacodelaluna ❤️ |
@pacodelaluna FYI the OFN docker image changed recently: #12905 |
@pacodelaluna sorry me again. Apologies I didn't pay a close attention to the screenshot the first time, and now that i'm playing with it I'm noticing that you've moved fields in the admin section that should remain accessible to enterprise managers/owners: These two need to stay in "primary details tab'. |
Hi @pacodelaluna sorry that you're having issues with Cuprite. I don't have time to help until next year sorry, but you can try posting in Slack #dev channel in case someone else can help. |
Apologies, I see I must have overridden you on the staging-FR server. I hope I did not cause too much trouble 🙏 |
no don't worry @filipefurtad0 and I see I've forgotten to remove the label 🤦♀️ please use it as much as you need on your timezone. FR team is developing a tool to automate invoices to OFN users, and this PR is needed for the tests, so I will stage it again in the next couples of days, but again feel free to use the staging during your time 💪 |
193be72
to
d90ca53
Compare
737f40b
to
b40e8a1
Compare
What? Why?
The objective is to improve the links between OFN enterprises and external billing tools, through the admin reports.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
Add external billing id on enterprises
The title of the pull request will be included in the release notes.
Documentation updates
No. The tip section should explain the objective of the new field with enough details.