Remove product SKU from product pages and report #12991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murjax
force-pushed
the
remove-sku-11973
branch
from
b5fc7f6 to
bab7756
Compare
mkllnk
approved these changes
Nov 21, 2024
Comment on lines
-37
to
+38
| "ABC", Spree::Product.first.name.to_s, "1g", "1", "none", "10.0", "none", "Check", | ||
| variant.sku, Spree::Product.first.name.to_s, "1g", "1", "none", "10.0", "none", "Check", |
There was a problem hiding this comment.
It's better to use the actual value in specs. Otherwise we may miss a bug, for example if the sku is nil and the report fails to print the sku then this test would still pass.
mkllnk
added
the
user facing changes
dacook
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This removes the product SKU from the UI to remove ambiguity with the variant SKU.
Pages impacted:
/admin/products/)/admin/products/:id/edit)/admin/reports/orders_and_distributors)What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates