Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old, replaced backorder lookup #13044

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Dec 17, 2024

ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code #11678 DFC Orders

What? Why?

When we create a new DFC backorder, we store a link to it:

But that pull request kept the old logic of finding any open DFC order for backwards compatibility. We are not stripping that out.

What should we test?

  • Complete an order cycle with orders that trigger a backorder.
  • The backorder should get amended and completed correctly.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk self-assigned this Dec 17, 2024
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Dec 17, 2024
@mkllnk mkllnk marked this pull request as ready for review December 17, 2024 06:06
@mkllnk mkllnk added the pr-staged-uk staging.openfoodnetwork.org.uk label Dec 17, 2024
@RaggedStaff RaggedStaff linked an issue Dec 18, 2024 that may be closed by this pull request
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see code being maintained so well 💯

@dacook
Copy link
Member

dacook commented Jan 2, 2025

Does the staged label need removing?

@mkllnk mkllnk removed the pr-staged-uk staging.openfoodnetwork.org.uk label Jan 2, 2025
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@rioug rioug merged commit ab57618 into openfoodfoundation:master Jan 5, 2025
56 checks passed
@mkllnk mkllnk deleted the dfc-store-order-links-only branch January 6, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DFC Orders] - Order Cancellations not recalculating correctly
3 participants