Improve error message for n.times syntax #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add specs.
The specs are more important, so run them first. Runtime is pretty similar at the moment.
mkllnk
commented
Apr 12, 2024
Comment on lines
+34
to
+37
| if expected.is_a?(Enumerator) && expected.inspect.match?(/:times>$/) | ||
| expected = expected.size | ||
| end | ||
|
|
There was a problem hiding this comment.
I was thinking today that we should create a new object:
@matcher = QueryMatcher.new(@queries)
@matcher.matches?(expected)That matcher would implement the different cases of comparing to different types. It would be easier to test that class and by storing it in an ivar, we can re-use it to print the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add specs.