Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused functions, attributes, logic #27

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

mattwthompson
Copy link
Member

  • InChI keys were used in minimizations but not needed
  • A questionable isomorphism check is now removed
  • Some forgotten-about minimization helpers are removed
  • A unit test for CachedResultCollection is added

* InChI keys were used in minimizations but not needed
* A questionable isomorphism check is now removed
* Some forgotten-about minimization helpers are removed
* A unit test for `CachedResultCollection` is added
@codecov-commenter
Copy link

Codecov Report

Merging #27 (dc1ac47) into main (1584974) will increase coverage by 0.65%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson merged commit 8fd7168 into main Mar 12, 2024
1 check passed
mattwthompson added a commit that referenced this pull request Mar 29, 2024
@mattwthompson mattwthompson deleted the cleanup branch November 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants