-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: now() function timezone offset #3040
Conversation
…is/arena into fix/now-function-timezone-offset
Are there any way to solve this without use the timezone? I mean using the iso date with the timezone. |
I think that the easiest thing to solve this without passing the timezone or the timezone offset to the server is to store the time as a Date in ISO format, then format it in the client using its timezone... is this what you mean? |
yes, use the iso data all the time |
I've just tried, the problem is that this approch introduces other pains elsewhere, e.g. in expressions that compare date or time attributes... even in that case you will have to pass the client timezone. a this point it's better to keep the storage format as it is and calculate the offset when the value is stored. |
Where are the expressions evaluated? at the same timezone of the user (client side)? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
for the expressions validation client side, otherwise server side |
they are evaluated in NodeDefValidator, at the same timezone of the client, but the record updater runs server side, ignoring the client timezone |
fixes #3035