Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor FormItem (label translation) #3596

Merged
merged 10 commits into from
Oct 15, 2024
Merged

refactor FormItem (label translation) #3596

merged 10 commits into from
Oct 15, 2024

Conversation

SteRiccio
Copy link
Member

@SteRiccio SteRiccio commented Oct 11, 2024 •
edited
Loading

moved the use of i18next into FormItem component.
e.g. <FormItem label={i18n.t('common.name')}> changed into

@SteRiccio SteRiccio self-assigned this Oct 11, 2024
@SteRiccio SteRiccio marked this pull request as ready for review October 14, 2024 11:23
@SteRiccio SteRiccio requested a review from ramirobg94 October 14, 2024 11:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mergify mergify bot merged commit 026b048 into master Oct 15, 2024
6 checks passed
@mergify mergify bot deleted the refactor/form-item branch October 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramirobg94 ramirobg94 ramirobg94 approved these changes

Assignees

@SteRiccio SteRiccio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteRiccio @ramirobg94