-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: externalyse geometries management #868
Conversation
Codecov Report
@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 96.55% 96.57% +0.01%
==========================================
Files 39 39
Lines 3804 3796 -8
==========================================
- Hits 3673 3666 -7
+ Misses 131 130 -1
|
I recently added a class implementation of both of them, let's use this one instead |
@dfguerrerom any chance to get a review on this one or should I proceed with the merge ? |
give me a couple of days more please, these days have been a bit crazy. |
No problem I was just checking you were still around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a nice implementation, I'm not sure about the name of the classes but that's something non related with this PR.
I needed to get geometries both with and without GEE for my work and realized I didn't wanted to use the whole sepal_ui suits. The method developped for getting geometries were well designed so I exported it in their own libs: pygadm and pygaul.
In order to avoid duplicate work, and to reduce the size of sepal_ui I proposed in this PR to rely on these 2 extra libs to get GAUL and GADM data.
_from_admin
useget_items
method from both libget_names
in theAdminSelect
dropdownside effects:
I checked it manually and didn't changed any of the tests so normally if we did a decent job at making them this modification should be transparent in applications.
Fix #860