Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: externalyse geometries management #868

Merged
merged 9 commits into from
Sep 15, 2023
Merged

fix: externalyse geometries management #868

merged 9 commits into from
Sep 15, 2023

Conversation

12rambau
Copy link
Member

I needed to get geometries both with and without GEE for my work and realized I didn't wanted to use the whole sepal_ui suits. The method developped for getting geometries were well designed so I exported it in their own libs: pygadm and pygaul.

In order to avoid duplicate work, and to reduce the size of sepal_ui I proposed in this PR to rely on these 2 extra libs to get GAUL and GADM data.

  • I updated aoi_model so that _from_admin use get_items method from both lib
  • I updated the aoi_view to use get_names in the AdminSelect dropdown
  • dropped the parquet dataset and reduce the size of the lib
  • PyGAUL and pyGADM relies on requests_cahce for managing their download so they are faster than the regular downnloads we were using.

side effects:

  • I corrected the bug with the planet data_regression.
  • There was a small bug with the aoi_view when used without map (reset was bugging because of the w_draw v_model)

I checked it manually and didn't changed any of the tests so normally if we did a decent job at making them this modification should be transparent in applications.

Fix #860

@12rambau 12rambau marked this pull request as ready for review August 14, 2023 21:33
@12rambau 12rambau requested a review from dfguerrerom August 14, 2023 21:33
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #868 (7a32787) into main (6b5eee2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7a32787 differs from pull request most recent head 358194e. Consider uploading reports for the commit 358194e to get more accurate results

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   96.55%   96.57%   +0.01%     
==========================================
  Files          39       39              
  Lines        3804     3796       -8     
==========================================
- Hits         3673     3666       -7     
+ Misses        131      130       -1     
Files Changed Coverage Δ
sepal_ui/aoi/aoi_model.py 89.02% <100.00%> (-0.17%) ⬇️
sepal_ui/aoi/aoi_view.py 98.91% <100.00%> (+0.03%) ⬆️

@12rambau 12rambau marked this pull request as draft August 31, 2023 08:15
@12rambau
Copy link
Member Author

I recently added a class implementation of both of them, let's use this one instead

@12rambau 12rambau marked this pull request as ready for review August 31, 2023 19:38
@12rambau
Copy link
Member Author

@dfguerrerom any chance to get a review on this one or should I proceed with the merge ?

@dfguerrerom
Copy link
Collaborator

@dfguerrerom any chance to get a review on this one or should I proceed with the merge ?

give me a couple of days more please, these days have been a bit crazy.

@12rambau
Copy link
Member Author

No problem I was just checking you were still around

Copy link
Collaborator

@dfguerrerom dfguerrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice implementation, I'm not sure about the name of the classes but that's something non related with this PR.

@12rambau 12rambau merged commit 20900dd into main Sep 15, 2023
@12rambau 12rambau deleted the aoi_model branch September 15, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

use pygaul and pygadm in aoi_model
2 participants