Use getDeviceIds function to list audio devices instead of relying on contiguous IDs #8017
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
msys2: macOS will be fixed for 6.0.1 after merge of #7889 |
|
I'll see about contributing an update to RtAudio 6.0.1 on msys2's end; based on the PKGBUILD it seems like it should be relatively straightforward. Also, the Linux build is failing due to what appears to be a missing dependency (curl specifically). Is that something that needs to be fixed too? |
|
Please tag your head change, then rebase it ontop of current upstream
master.
What we can do is use RT audio defines for the meantime set in code while
we await the fix for msys2.
…On Thu, 4 Jul 2024 at 2:26 PM, Evergreen ***@***.***> wrote:
I'll see about contributing an update to RtAudio 6.0.1 on msys2's end;
based on the PKGBUILD it seems like it should be relatively
straightforward. Also, the Linux build is failing due to what appears to be
a missing dependency (curl specifically). Is that something that needs to
be fixed too?
—
Reply to this email directly, view it on GitHub
<#8017 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGK2HEEIQHAVJQ5QCHOOU3ZKTFITAVCNFSM6AAAAABJFSCUXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGA4TKOJUGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
As of RtAudio 6.0.0 you cannot assume that devices will fall in the range [0, getDeviceCount() - 1]. Doing so will potentially cause errors or out of bounds array accesses depending on the platform.
EvergreenTheTree
force-pushed
the
rtaudio_device_list_fix
branch
from
88226ce
to
aa70b92
Compare
|
Rebased; also made a pull request for updating RtAudio in msys2: msys2/MINGW-packages#21319 UPDATE: the msys2 rtaudio 6.0.1 package update has now been merged and is in the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8013
As of RtAudio 6.0.0 you cannot assume that devices will fall in the range [0, getDeviceCount() - 1]. Doing so will potentially cause errors or out of bounds array accesses depending on the platform.
I am not super familiar with this project, but as far as I can tell I couldn't find any documentation or example projects that would need to be updated as a result of this change. However, I do know of at least two projects (audiostellar and ofxPDSP) that make this assumption, so it is definitely worth noting in the change log.