Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFLAGS array fix #441

Merged
merged 1 commit into from
Nov 16, 2023
Merged

CFLAGS array fix #441

merged 1 commit into from
Nov 16, 2023

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Nov 16, 2023

Address a problem where only the latest CFLAG entry was being added.
cc: @danomatika
this is the result of ofxPd pdExample project, after the change

Screenshot 2023-11-16 at 20 04 22

Potentially closes #440

@danomatika
Copy link
Contributor

I suggest double-checking ADDONS_CPPFLAGS handling as well.

@danomatika
Copy link
Contributor

danomatika commented Nov 16, 2023

@ofTheo IMO This is needed for an OF 0.12.1 bugfix release. -> #440

@dimitre dimitre merged commit 63934b6 into openframeworks:master Nov 16, 2023
@dimitre dimitre deleted the pd branch November 16, 2023 23:19
@dimitre
Copy link
Member Author

dimitre commented Nov 16, 2023

@danomatika I've double checked everything that uses array in xcodeproject, all good.
Changes are already merged so it will be on 0.12.1
Nightly generated with changes will be available in 30 minutes
Can you please test your other addons, or addons you use frequently to see if there are any remaining PG issues? Thanks

@danomatika
Copy link
Contributor

I have updated all of my personal addons. I am not able to build iOS projects but I figured that's because I have an older macOS 13 and Xcode installed, so I didn't try debugging it.

@dimitre
Copy link
Member Author

dimitre commented Nov 16, 2023

I'm using macOS 13 too, it should be all good. let me know if you have issues with the addons, maybe there are things missing in iOS project generator

@dimitre
Copy link
Member Author

dimitre commented Nov 16, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem setting ADDON_CFLAGS in Xcode projects with OF 0.12 release PG
2 participants