Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addons parsing improvement (dont merge yet) #578
Addons parsing improvement (dont merge yet) #578
Changes from 25 commits
a3681b2
b371258
af588f4
db2ac57
8b462cd
8abbe8a
4a75fa6
351bc84
cae1fe0
4662abc
47373ed
f0538d2
92bd210
06695f2
7113d7c
e0860d1
b22c01c
87c6fe6
26160d3
c254a2c
a525826
df54108
bb6b022
1677f28
6b32307
ebc0a3f
abe0e5b
a136c43
082bbda
cf7d4b8
d9f7018
f42d113
382a587
d506085
35663f4
f2bd861
c941406
3c87dd9
490bbf1
47325ff
631f4c6
6c246c7
15db750
d9f71f6
61a771e
e8b4ab5
f543c4d
2a73311
bdd200d
39ee9b7
a97352e
e89d817
b4aab46
57a19aa
6b2b641
315f9c2
ac763b5
525512e
2a8de70
0071b23
dae2353
cf04c71
b7b93dc
34624c5
1c7d0cf
0957d79
5dfd6ae
c560c90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove virtual here once it is final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updatetd it. THanks for pointing out. Although, the linux test fails immediately when trying to pull ubuntu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @roymacdonald let's merge it.