🚸(apps) run the db_migrate job before starting application pods #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we run db_migrate after starting the new pod: - the current pod has to be compatible with the state of the db before and after the migration. - the new pod has to be compatible with the state of the database before and after a migration. This is not possible for a new database, and not easy for schema updates. If we run db_migrate before starting a new pod, the new pod only has to be compatible with the state of the database after the migration.
lunika
approved these changes
Dec 17, 2019
jmaupetit
suggested changes
Jan 28, 2020
| deployment_stamp: "{{ deployment_stamp }}" | ||
| job_stamp: "{{ job_stamp }}" | ||
| # Jobs with the "pre" job type will be executed prior to deployments | ||
| job_type: "pre" |
There was a problem hiding this comment.
Should be conditioned to non-trashable environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If we run db_migrate after starting the new pod:
If we run db_migrate before starting a new pod, the new pod only has to be
compatible with the state of the database after the migration.
Proposal
Tag all
db_migratejobs asprejobs.