Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(backend) allow IMS LIS LTI roles #2677

Merged
merged 2 commits into from
Jan 6, 2025
Merged

✨(backend) allow IMS LIS LTI roles #2677

merged 2 commits into from
Jan 6, 2025

Conversation

kernicPanel
Copy link
Member

Purpose

When parsing LTI role string from requests, we want to handle IMS LIS format.

Copy link
Member

@jbpenrath jbpenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a entry in the Changelog is missing otherwise LGTM

When parsing LTI role string from requests, we want to handle IMS LIS
format.
CHANGELOG.md Outdated Show resolved Hide resolved
Added

- Support for the IMS LIS role format in the LTI launch
Copy link
Contributor

@wilbrdt wilbrdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kernicPanel kernicPanel merged commit 0b443a1 into master Jan 6, 2025
33 checks passed
@kernicPanel kernicPanel deleted the lis-lti-role branch January 6, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants