Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rlecellier/dashboard teacher courses loading #1971

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rlecellier
Copy link
Collaborator

note: this PR is made on top of #1951

Purpose

Add a loading effect on teacher dashboard course list page

Proposal

  • useIsLoading: add minimum delay in order to see the animation. The idea is that it's better to see a loading effect during 0.5 sec than a instant blink.
  • animate new page loading with a fade animation.

Todo

We need to choose:

  • minimal loading time or not.
  • wich effect do we want ? :
    • a page fade like in this PR.
    • a page grey overlay
    • a background blink on each glimps.

We need Course to containe lot's more informations for our course
endpoint that well be make for teacher dashboard course page.
    Part of teacher dashboard development, list teacher courses.
add minimum loading time and transition when course apear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants