🐛(rdfa) fix errors on Google Search Console #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpenrath
reviewed
Jun 24, 2024
src/richie/apps/courses/templates/courses/cms/course_detail.html
Outdated
Show resolved
Hide resolved
src/richie/apps/courses/templates/courses/cms/course_detail.html
Outdated
Show resolved
Hide resolved
igobranco
force-pushed
the
igobranco/issues/2444/fix-rdfa
branch
2 times, most recently
from
e53a631
to
e2e4fbf
Compare
This was referenced Jun 26, 2024
Closed
igobranco
force-pushed
the
igobranco/issues/2444/fix-rdfa
branch
2 times, most recently
from
f9d1f6e
to
167c6ce
Compare
7 tasks
igobranco
force-pushed
the
igobranco/issues/2444/fix-rdfa
branch
from
167c6ce
to
78b7042
Compare
|
@jbpenrath I've updated this PR description, because this PR only fixes 2 of 3 problems identified by #2444. Can you review again so we can merge it? |
jbpenrath
reviewed
Jul 2, 2024
src/richie/apps/courses/templates/courses/cms/course_detail.html
Outdated
Show resolved
Hide resolved
igobranco
force-pushed
the
igobranco/issues/2444/fix-rdfa
branch
2 times, most recently
from
38a9939
to
c32cd7a
Compare
|
@jbpenrath I've also included a new test for the |
|
@jbpenrath do you want me to split the commit into 2 different fixes? |
Yes good idea! |
igobranco
force-pushed
the
igobranco/issues/2444/fix-rdfa
branch
3 times, most recently
from
af3bfd6
to
bb7babc
Compare
@jbpenrath I've splitted the commits! I think everything is done! Please done a last review so we can merge it! |
The hidden course runs enrollment count shouldn't be included on the course level enrollment count.
Google Search Console requires more information for the RDFa information. Fixed errors: - Missing field 'hasCourseInstance' - Either 'courseWorkload' or 'courseSchedule' should be specified (in 'hasCourseInstance') related to #2444
igobranco
force-pushed
the
igobranco/issues/2444/fix-rdfa
branch
from
bb7babc
to
8cf5460
Compare
JoaoGarcao
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Jul 26, 2024
Added offer and price fields to courseRun displayed at admin view fix openfun#2445
JoaoGarcao
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Jul 26, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
JoaoGarcao
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Jul 26, 2024
Make offer and price editable using course run sync API related to openfun#2445
JoaoGarcao
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Jul 29, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
JoaoGarcao
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Aug 2, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
JoaoGarcao
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Aug 2, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
JoaoGarcao
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Aug 6, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
igobranco
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Nov 5, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445 Co-authored-by: Ivo Branco <[email protected]>
igobranco
added a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Nov 5, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445 Co-authored-by: Ivo Branco <[email protected]>
igobranco
pushed a commit
to JoaoGarcao/richie-estagio
that referenced
this pull request
Nov 7, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
Tiago-Salles
added a commit
to Tiago-Salles/richie
that referenced
this pull request
Nov 7, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
Tiago-Salles
added a commit
to Tiago-Salles/richie
that referenced
this pull request
Nov 8, 2024
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Search Console requires more information for the RDFa information.
Fixes 2 of 3 problems identified by #2444:
To validate copy paste a course page html code to the Google Search Console validator:
https://search.google.com/test/rich-results/result