-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update annex-d-geopose-frame-specs.adoc per comments from @rouault #84
Open
3DXScape
wants to merge
1
commit into
main
Choose a base branch
from
Editor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rouault Please review this.
Looking closer, there are 2 things I'm wondering for the NED CRS:
You may want to ask about that on https://lists.ogc.org/mailman/listinfo/coordtran.wg |
* I think that U, V, W are Cartesian coordinate placeholders that imply that there is some transformation from X,Y,Z involved. But that’s just a feeling based on my physics background. I had the same question for ENU and decided that naming the axes “east”, “north”, and “up” was the clearest editorial choice. I followed U, V, W for NED to follow your contribution. I have seen (X,Y,Z), (xNorth, yNorth, zDown), (N, E, D), (U, V, W). In the end, these are just parameters with arbitrary placeholder names. If I controlled the Universe, I would use (north, east, down).
* I think that 9836 is probably *not* designed for NED. I could not find a better fit that was not “EPSG:9837 with the third axis reversed”. Maybe one way to approach this would be in the WKT we are discussing here, but I am such a non-expert with WKT-speak that I do not know how to say “use EPSG:9837 transformation but reverse the third coordinate”. I am hoping that you or one of your colleagues have a suggestion.
…steve
From: Even Rouault ***@***.***>
Sent: Wednesday, June 5, 2024 10:31 AM
To: opengeospatial/GeoPose ***@***.***>
Cc: Carl Smyth ***@***.***>; Author ***@***.***>
Subject: Re: [opengeospatial/GeoPose] Update annex-d-geopose-frame-specs.adoc per comments from @rouault (PR #84)
Looking closer, there are 2 things I'm wondering for the NED CRS:
* do the abbreviations U, V, W still apply when it is a NED coordinate system. The U, V, W are nominally designed for the ENU coordinate system. It has never been clear to me how the logic of attributing abbreviations worked.
* I'm not sure if the "Geographic/topocentric conversions" EPSG:9836 is expected to be used with a NED coordinate system. That implies that implementations of the conversion should look at the declared axis order to do the easting/northing axis swap and invert the sign of the height to be a depth where needed. Generally in the EPSG dataset, when there are projections that require "unusual" axis order, like Transverse Mercator South Oriented, they have their own code.
You may want to ask about that on https://lists.ogc.org/mailman/listinfo/coordtran.wg
—
Reply to this email directly, view it on GitHub<#84 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABAQF3U4GCMR3LL26WQCQ6LZF5DODAVCNFSM6AAAAABI3E2GZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGU4TGOJZG4>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Actually “Use EPSG:9837, swap the first two axes and reverse the third axis”. …
From: Carl Smyth
Sent: Wednesday, June 5, 2024 11:32 AM
To: opengeospatial/GeoPose ***@***.***>; opengeospatial/GeoPose ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [opengeospatial/GeoPose] Update annex-d-geopose-frame-specs.adoc per comments from @rouault (PR #84)
* I think that U, V, W are Cartesian coordinate placeholders that imply that there is some transformation from X,Y,Z involved. But that’s just a feeling based on my physics background. I had the same question for ENU and decided that naming the axes “east”, “north”, and “up” was the clearest editorial choice. I followed U, V, W for NED to follow your contribution. I have seen (X,Y,Z), (xNorth, yNorth, zDown), (N, E, D), (U, V, W). In the end, these are just parameters with arbitrary placeholder names. If I controlled the Universe, I would use (north, east, down).
* I think that 9836 is probably *not* designed for NED. I could not find a better fit that was not “EPSG:9837 with the third axis reversed”. Maybe one way to approach this would be in the WKT we are discussing here, but I am such a non-expert with WKT-speak that I do not know how to say “use EPSG:9837 transformation but reverse the third coordinate”. I am hoping that you or one of your colleagues have a suggestion.
…steve
From: Even Rouault ***@***.******@***.***>>
Sent: Wednesday, June 5, 2024 10:31 AM
To: opengeospatial/GeoPose ***@***.******@***.***>>
Cc: Carl Smyth ***@***.******@***.***>>; Author ***@***.******@***.***>>
Subject: Re: [opengeospatial/GeoPose] Update annex-d-geopose-frame-specs.adoc per comments from @rouault (PR #84)
Looking closer, there are 2 things I'm wondering for the NED CRS:
* do the abbreviations U, V, W still apply when it is a NED coordinate system. The U, V, W are nominally designed for the ENU coordinate system. It has never been clear to me how the logic of attributing abbreviations worked.
* I'm not sure if the "Geographic/topocentric conversions" EPSG:9836 is expected to be used with a NED coordinate system. That implies that implementations of the conversion should look at the declared axis order to do the easting/northing axis swap and invert the sign of the height to be a depth where needed. Generally in the EPSG dataset, when there are projections that require "unusual" axis order, like Transverse Mercator South Oriented, they have their own code.
You may want to ask about that on https://lists.ogc.org/mailman/listinfo/coordtran.wg
—
Reply to this email directly, view it on GitHub<#84 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABAQF3U4GCMR3LL26WQCQ6LZF5DODAVCNFSM6AAAAABI3E2GZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGU4TGOJZG4>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rouault Please review this.