Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust mkdocs-insiders version #390

Closed
wants to merge 3 commits into from
Closed

Conversation

why-not-try-calmer
Copy link
Contributor

@why-not-try-calmer why-not-try-calmer commented Oct 24, 2023

Can we do without insiders? I always forget why we need to declare it as a build dependency.

@suricactus
Copy link
Collaborator

It brings a bit extra things, don't remember exactly what. Last time I checked it was still used.

To test without merging we should rather add the insiders deps in the lint-and-test than commenting it in the build that only runs on master.

@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Oct 24, 2023

This begs for an update of our forks of mkdocs-insiders, zero-ing in on the "recent but not too recent" sweet spot.

@why-not-try-calmer why-not-try-calmer changed the title Commented out insiders dependencies Adjust mkdocs-insiders version Oct 24, 2023
@suricactus
Copy link
Collaborator

Found the culprit. It is the social plugin.

Tried with and a bit more, without success.:

  - social:
      # See https://squidfunk.github.io/mkdocs-material/setup/setting-up-social-cards/
      concurrency: 1
      debug: true
      log_level: warn
      cards_color:
        fill: "#72ad2e"
        text: "#FFFFFF"

I have reported the issue squidfunk/mkdocs-material#6241 .

@suricactus
Copy link
Collaborator

See workaround solution here: #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants