Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated site description in DE and IT #392

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Translated site description in DE and IT #392

merged 5 commits into from
Nov 3, 2023

Conversation

suricactus
Copy link
Collaborator

@signedav your Deutsch is need to proofread in German :)

@suricactus suricactus requested a review from signedav October 24, 2023 23:12
mkdocs.yml Outdated Show resolved Hide resolved
@m-kuhn
Copy link
Member

m-kuhn commented Oct 25, 2023

Slightly OT:

In this pages we provide comprehensive and easy-to-understand documentation for all of our products.

Is there any value for the reader in this sentence?
I guess he already knows this is the documentation and can decide himself if it's comprehensive and easy to understand after his visit.

@signedav
Copy link
Member

Is there any value for the reader in this sentence? I guess he already knows this is the documentation and can decide himself if it's comprehensive and easy to understand after his visit.

Maybe it implies that there are documentation for (a) every single product and not only generally for the ecosystem and (b) here are not only experts info but as well easy and the other way around. It is in fact a little bit a "Floskel", but the next sentence as well, but then we can discuss if we need an entry sentence at all, no?

@m-kuhn
Copy link
Member

m-kuhn commented Oct 25, 2023

Is there any value for the reader in this sentence? I guess he already knows this is the documentation and can decide himself if it's comprehensive and easy to understand after his visit.

Maybe it implies that there are documentation for (a) every single product and not only generally for the ecosystem and (b) here are not only experts info but as well easy and the other way around. It is in fact a little bit a "Floskel", but the next sentence as well, but then we can discuss if we need an entry sentence at all, no?

What I expect from a "welcome to" page is, that it gives context what this page is for (a suit of products for field work) or who it is for (devs, end users, beginners, advanced ...) or otherwise gives me hints if this page is what I was looking.

@suricactus
Copy link
Collaborator Author

Having the third sentence highlighting how easy and comprehensive are the docs, probably Matthias is right we should drop the middle sentence.

Since the PR is about languages I don't speak, can @m-kuhn take over and merge/approve whenever this is ready?

Co-authored-by: signedav <[email protected]>
mkdocs.yml Outdated Show resolved Hide resolved
@ZsanettMed
Copy link
Contributor

Another vote for @m-kuhn -> dropping the middle sentence!

@m-kuhn
Copy link
Member

m-kuhn commented Oct 25, 2023

Another vote for @m-kuhn -> dropping the middle sentence!

It's removed, except for Japanese/Chinese, where I wasn't able

Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this forward, we can add more later

@m-kuhn m-kuhn merged commit 6d8e973 into master Nov 3, 2023
2 checks passed
@m-kuhn m-kuhn deleted the de_it branch November 3, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants