Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pictures.en.md #395

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Update pictures.en.md #395

merged 6 commits into from
Dec 4, 2023

Conversation

rosaguilar
Copy link
Contributor

Add information about capturing and storing EXIF info of pictures.
Cheers from SA

Add information about capturing and storing EXIF info of pictures.
Copy link
Member

@lucienicolier lucienicolier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosaguilar Thank you so much for your contribution.
I have added a few suggestions.

documentation/how-to/pictures.en.md Outdated Show resolved Hide resolved
documentation/how-to/pictures.en.md Outdated Show resolved Hide resolved
documentation/how-to/pictures.en.md Outdated Show resolved Hide resolved
Copy link
Member

@lucienicolier lucienicolier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosaguilar I just changed the title to make it clearer

documentation/how-to/pictures.en.md Outdated Show resolved Hide resolved
Fix white space
@lucienicolier lucienicolier merged commit abc2f1e into opengisch:master Dec 4, 2023
2 checks passed
@m-kuhn
Copy link
Member

m-kuhn commented Dec 4, 2023

Something went wrong here: image
https://docs.qfield.org/how-to/pictures/#fetching-geotags-exif-from-the-image-file-into-the-attribute-table
I think the link to the QGIS docs ended up as an image instead of a link. @lucienicolier @rosaguilar can you have a look?

@rosaguilar
Copy link
Contributor Author

rosaguilar commented Dec 4, 2023 via email

lucienicolier added a commit that referenced this pull request Dec 4, 2023
@lucienicolier
Copy link
Member

Thanks for noticing. I removed the !! before the link. Best, Rosa

@rosaguilar this wasn't the issue. The picture has not been uploaded in documentation/assets/images

@m-kuhn
Copy link
Member

m-kuhn commented Dec 4, 2023

This PR has already been merged 5 hours ago.
Can someone create a new pull request (from master) with a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants