Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to Open default camera #455

Closed
wants to merge 1 commit into from

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented May 2, 2024

No description provided.

@SeqLaz SeqLaz requested a review from m-kuhn May 2, 2024 13:19
@nirvn
Copy link
Member

nirvn commented Jun 1, 2024

@SeqLaz , this will need some tweaking. For one, the settings UI has changed a bit for QField 3.3, so we should update the image in there.

But more importantly, I don't think we should say that disabling the native camera is the "recommended" option. If it was unconditionally the case, we'd switch to that by default :) But, if users experience crash due to memory limitations on their devices, they are recommended to switch.

@m-kuhn
Copy link
Member

m-kuhn commented Jun 2, 2024

I think this was triggered by a translation problem.

@koenigherford posted a screenshot of a german docs page which still mentioned open camera, the same reference isn't in the english version afaics.

Shall we close this pr, someone should fix the german translation on transifex and the screenshot be updated in a new pr?

@nirvn
Copy link
Member

nirvn commented Jun 2, 2024

Yeah let's close this.

@nirvn nirvn closed this Jun 2, 2024
@m-kuhn m-kuhn deleted the QF-4099-remove-the-reference-to-open-camera branch June 2, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants