Relation editor widget's print child feature atlas layout to PDF #6031
+475
−475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elation editor widget
… feature in there
nirvn
commented
Feb 22, 2025
| } | ||
| } | ||
|
|
||
| Loader { |
There was a problem hiding this comment.
The use of a loader here is to defer the cost involved in atlas-related item / model generation until we open the menu.
There was a problem hiding this comment.
Do you want to leave that as a comment in the file, so someone working on this in the future will directly know?
|
🎉 Ta-daaa, freshly created APKs are available for 48b1851: arm64-android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to print an atlas PDF tied to children of a parent within the parent feature form through the addition of actions within the relation editor widget's list. Here's how it looks like:
As the screenshot shows, the work here led to the delete button being relocated into the 3-dot menu. Since it has become far less easy to accidentally tap on the delete button, it's now enabled all the time (irrespective of the feature form's editing state), just like we can delete the parent through its feature form all the time.
For good taste, I've also added a copy feature attributes to clipboard action. Interesting possibilities ahead of us! Thanks to Vevey for supporting this development.
Note that I've taken the time to de-duplicate tons of code shared across the relation editor and the ordered relation editor items. This makes the maintenance of these two sub types much easier as most fixes won't have to be applied in two different locations.