Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit service settings via tableView #4

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Edit service settings via tableView #4

merged 2 commits into from
Apr 15, 2024

Conversation

gacarrillor
Copy link
Contributor

Avoid changing current edit service without saving/discarding.

Screenshot from 2024-04-12 15-33-23

@3nids 3nids closed this Apr 12, 2024
@3nids 3nids reopened this Apr 12, 2024
Copy link
Member

@3nids 3nids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't look precisely into the model, but the UI is looking great! Love it!

'dbname': 'qgis_test_db2'}
_settings = {
"host": "localhost",
"port": "5433",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"port": "5433",
"port": "5432",

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are/were just quick tests. There I was changing parameters so that the overwrite result was even more evident.

BTW, those quick tests could eventually become unit tests in this repo.

def __init__(self, iface):
self.iface = iface
self.action = None

def initGui(self):
self.action = QAction('Go!', self.iface.mainWindow())
self.action = QAction("Go!", self.iface.mainWindow())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's create an icon for the plugin (in another PR it's fine)

@gacarrillor gacarrillor merged commit f31d7e9 into main Apr 15, 2024
4 checks passed
@gacarrillor gacarrillor deleted the edit_service branch April 15, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants