Skip to content

Commit

Permalink
feat: rename NRIC field to NRIC/FIN (#6759)
Browse files Browse the repository at this point in the history
* feat: rename NRIC field to NRIC/FIN

* chore: set 5s timeout for frontend tests

* chore: set timeout in cli call

* Revert "chore: set timeout in cli call"

This reverts commit 401d45e.

* chore: increase memory to 2gb for frontend test

* chore: increase memory to 4gb
  • Loading branch information
tshuli authored Oct 2, 2023
1 parent 395aaa6 commit 1f91bba
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ jobs:
- src/**
- package.json
- package-lock.json
install:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -96,7 +95,10 @@ jobs:
with:
path: '**/node_modules'
key: ${{ runner.OS }}-node-modules-${{ hashFiles('**/package-lock.json') }}
- run: npm run test:frontend
- name: Run frontend test
env:
NODE_OPTIONS: --max-old-space-size=4096
run: npm run test:frontend

frontend_lint:
needs: [changes, install]
Expand Down
1 change: 1 addition & 0 deletions frontend/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ const esModules = ['react-markdown'].join('|')

module.exports = {
transformIgnorePatterns: [`node_modules/(?!${esModules})/`],
testTimeout: 5000,
}
2 changes: 1 addition & 1 deletion frontend/src/features/admin-form/create/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const BASICFIELD_TO_DRAWER_META: {
},

[BasicField.Nric]: {
label: 'NRIC',
label: 'NRIC/FIN',
icon: BiUser,
isSubmitted: true,
},
Expand Down

0 comments on commit 1f91bba

Please sign in to comment.