fix: error handling in validateStorageSubmission

src/app/modules/myinfo/myinfo.service.ts

@@ -441,7 +441,7 @@ export class MyInfoServiceClass {
         })
         return errAsync(new MyInfoHashDidNotMatchError())
       }
-      return okAsync(new Set(comparedFieldIds))
+      return errAsync(new MyInfoHashDidNotMatchError())
     })
   }
 

src/app/modules/submission/encrypt-submission/encrypt-submission.middleware.ts

@@ -395,6 +395,7 @@ export const validateStorageSubmission = async (
   next: NextFunction,
 ) => {
   const formDef = req.formsg.formDef
+  let spcpSubmissionFailure: undefined | true
 
   const logMeta = {
     action: 'validateStorageSubmission',
@@ -460,8 +461,8 @@ export const validateStorageSubmission = async (
       const { authType } = form
       switch (authType) {
         case FormAuthType.SGID_MyInfo:
-        case FormAuthType.MyInfo:
-          return extractMyInfoLoginJwt(req.cookies, authType)
+        case FormAuthType.MyInfo: {
+          const populatedForm = extractMyInfoLoginJwt(req.cookies, authType)
             .andThen(MyInfoService.verifyLoginJwt)
             .asyncAndThen(({ uinFin }) =>
               MyInfoService.fetchMyInfoHashes(uinFin, form._id)
@@ -479,18 +480,18 @@ export const validateStorageSubmission = async (
                 ),
             )
             .mapErr((error) => {
+              spcpSubmissionFailure = true
               logger.error({
                 message: `Error verifying MyInfo${
                   authType === FormAuthType.SGID_MyInfo ? '(over SGID)' : ''
                 } hashes`,
                 meta: logMeta,
                 error,
               })
-              const { statusCode, errorMessage } = mapRouteError(error)
-              return res.status(statusCode).json({
-                message: errorMessage,
-              })
+              return error
             })
+          return populatedForm
+        }
         default:
           return ok<IPopulatedStorageFormWithResponsesAndHash, never>({
             parsedResponses,
@@ -513,6 +514,7 @@ export const validateStorageSubmission = async (
       })
       return res.status(StatusCodes.INTERNAL_SERVER_ERROR).json({
         message: 'Error saving responses in req.body',
+        spcpSubmissionFailure,
       })
     })
 }