build: release v6.83.0 #6822
Closed
build: release v6.83.0 #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: use fe app URL for local dev redirect * feat: add new myinfo sgid fields new fields: sex, race, nationality, housingtype, hdbtype * feat: add registered address * feat: log if missing myinfo field is from sgid or singpass login * feat: use isDataReadOnly property * feat: add growthbook * feat: add more sgid fields * chore: promote -sgid config to use env site name (cherry picked from commit e9d9288) * fix: fix linting errors * feat: change formatVehicles input type * fix: set agency shortname as growthbook attribute * fix: catch errors when parsing vehicles * feat: account for blank fields * feat: account for NA in missing field values check * fix: clean up code * fix: remove comment * fix: include SGID_SUPPORTED_V1 in SGID_SUPPORTED_V1 * fix: include more details in comment * feat: add logging to _isDataReadOnly for Singpass and SGID MyInfo * fix: remove console.log statement * feat: update mobile_number_with_country_code scope * fix: return empty string when fieldValue is NA --------- Co-authored-by: Ken <[email protected]>
* feat: use pocdex sgid employment scope * feat: fe sgid page, components * fix: req.session typing * feat: add be profiles handling, refactor callback to profile-select * feat: add be routes * fix: add cleaning of response from sgid * feat: handle multi-employment profiles * feat: add error modals * chore: ui design changes on login page * feat: handle empty workprofiles * refactor: convert to async func * refactor: add utils to resolve redirection to local fe url * chore: remove test code * feat: add expiry to prevent login jacking * fix: add error toasts * chore: remove unused type * refactor: rename logincallbackpage to selectprofilepage * chore: add jsdocs comments * chore: remove test code * feat: add cta support url * refactor: move constant external urls to shared constants * chore: promote -sgid config to use env site name * fix: fix playwright finding two button elements * chore: update scope from public_officer_employments to public_officer_details * fix: update to match typing returned from sgid * chore: use agencies instead of organisations in copy * chore: use statuscode constants * refactor: extract apikey as const
build: merge release 6.82.0 into develop
…end (#6810) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.1 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…erless/virus-scanner (#6809) chore(deps-dev): bump @babel/traverse in /serverless/virus-scanner Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.11 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add residential status and workpassexpirydate * feat: add more myinfo fields * fix: fix typos in scopes * feat: update copy to reflect field parity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
#6819#6821#6820#6808#6815#6807#6801#6763#6766#68000e9c4bcDependencies
Dev-Dependencies
#6809#6810Tests
feat(sgid-login): general availability and multi-employment
#6763@wanlingt
Note: See ticket for instructions to install the chrome extension to help in testing sgid login.
Regression
OTP login, logout
/dashboardNew Feature
sgID login flow happy flow
/login/select-profilebrings you back to/login/dashboardbrings you back to/loginLog in with singpass appwill bring you to sgid login page where you are presented with a qrcode/login/select-profilewith 1 accountPrevent sgID login-jacking; expire select-profile session
Log in with singpass app, and scan the QRCode/login/select-profilepage/login/select-profilefor more than 5 minutes/loginafter 5 minsNo work employment admin
Log in with singpass app, and scan the QRCode (find a profile that has no work employment)/login/select-profilepageSingpass login isn't available to you yet/loginMulti-work employment admin
Log in with singpass app, and scan the QRCode (find a profile that has multiple work employment)/login/select-profilepage/login/select-profileNote: profile switching is an out-of-scope feature, that is can be extended in the future
Non-whitelisted admin login
Log in with singpass app, and scan the QRCode (find a profile that is not from a whitelisted domain)/login/select-profilepageYou don't have access to this service/loginfeat(sgid-myinfo): add even more sgid myinfo fields
#6807feat: add more myinfo sgid fields
#6766Regression Test
Deploy Notes
feat(sgid-myinfo): add even more sgid myinfo fields
#6807and feat: add more myinfo sgid fields#6766truefor OGP, default is set tofalse), adjust the growthbook rollout percentage accordinglyfeat(sgid-login): general availability and multi-employment
#6763SGID_ADMIN_LOGIN_REDIRECT_URIto be updated tohttps://form.gov.sg/api/v3/auth/sgid/login/callback'with their respectively subdomains forstaging,staging-alt,staging-alt2,uat, andprodpocdex.public_officer_details) on developer.id.gov.sg