Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dockerfile): update mocktwilio to start asap #6862

Merged
merged 1 commit into from
Nov 1, 2023
Merged

chore(dockerfile): update mocktwilio to start asap #6862

merged 1 commit into from
Nov 1, 2023

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Oct 31, 2023

Problem

mocktwilio starts late on dev as it waits for backend to be first started (note: not completed). However, there's no need for mocktwilio to start late.

Solution

Removed depends_on: backend for mocktwilio

Breaking Changes

  • No - this PR is backwards compatible

@KenLSM KenLSM enabled auto-merge (squash) October 31, 2023 07:05
wanlingt
wanlingt approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@wanlingt wanlingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@KenLSM KenLSM merged commit 59171c1 into develop Nov 1, 2023
22 checks passed
@KenLSM KenLSM deleted the chore/remove-mocktwilio-docker-bootorder branch November 1, 2023 09:23
@KenLSM KenLSM mentioned this pull request Nov 6, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanlingt wanlingt wanlingt approved these changes

@justynoh justynoh Awaiting requested review from justynoh

@tshuli tshuli Awaiting requested review from tshuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @wanlingt