Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.160.0 #7883

Closed
wants to merge 3 commits into from
Closed

build: release v6.160.0 #7883

wants to merge 3 commits into from

Conversation

kevin9foong
Copy link
Contributor

New

  • fix: mrf be validation isSignatureTimeValid false positive #7878
  • fix: add validation for myinfo child name field #7875
  • fix: drawer date picker invalid selection bug #7866
  • fix: add validation rules to controller #7874
  • fix: make children body input components controlled from the start #7871
  • feat(i18n): add en-sg locale for AddRowFooter #7867
  • build: merge release v6.159.0 to develop #7868
  • build: release v6.159.0 #7865
  • chore: bump version to v6.160.0 e5116ba

Dependencies

  • fix(deps): bump libphonenumber-js from 1.11.13 to 1.11.14 in /shared #7872
  • fix(deps): bump libphonenumber-js from 1.11.12 to 1.11.13 in /shared #7858

Dev-Dependencies

  • chore(deps-dev): bump @typescript-eslint/eslint-plugin from 8.12.2 to 8.14.0 in /shared #7877

Tests

fix: add validation for myinfo child name field #7875

myinfo child fields are properly validated as required by the FE.

  • Create a myinfo child field with all subfields
  • Submit the form and leave it empty, ensure that the required FE validation error message is shown for all fields
  • select a child which does prefill -> ensure that the prefilled fields no longer have an error
  • submit and notice that secondary race which is not prefilled still has a required error
  • fill it up and submit -> ensure that it works fine

fix: drawer date picker invalid selection bug #7866

date reflects correctly after custom date range selection:

  • Create a storage mode form with form field
  • Select custom date validation and check the range on the form field builder is correct when the drawer is extended.
  • Save the form field setting.
  • Try to preview the form and check the date field. ensure the valid date range is correct.
  • Try to submit the form and check the date field. ensure the valid date range is correct.

fix: add validation rules to controller #7874

Assert that the FE validation for my info child sub fields work

  • Create an email mode form with my info child field
  • Include all myinfo child subfields
  • Submit the form, try to submit with missing / invalid values and ensure FE validation works for all subfields.

fix: make children body input components controlled from the start #7871

Regression on myinfo child fields combo box data
  • Create an email mode form + all child fields + some other fields (eg, short text, checkbox)
  • Make a submission to the field on mobile as a respondent, try to fill up the different child fields and change children etc.
  • Repeat submission 2-3 times and ensure that the submission does not hang.

chore: bump version to v6.160.0 e5116ba

fix: make children body input components controlled from the start #7871

######## Regression on myinfo child fields combo box data

  • Create an email mode form + all child fields + some other fields (eg, short text, checkbox)
  • Make a submission to the field on mobile as a respondent, try to fill up the different child fields and change children etc.
  • Repeat submission 2-3 times and ensure that the submission does not hang.
fix: add validation rules to controller #7874

myinfo child fields are properly validated as required by the FE.

  • Create a myinfo child field with all subfields
  • Submit the form and leave it empty, ensure that the required FE validation error message is shown for all fields
  • select a child which does prefill -> ensure that the prefilled fields no longer have an error
  • submit and notice that secondary race which is not prefilled still has a required error
  • fill it up and submit -> ensure that it works fine
fix: drawer date picker invalid selection bug #7866

date reflects correctly after custom date range selection:

  • Create a storage mode form with form field
  • Select custom date validation and check the range on the form field builder is correct when the drawer is extended.
  • Save the form field setting.
  • Try to preview the form and check the date field. ensure the valid date range is correct.
  • Try to submit the form and check the date field. ensure the valid date range is correct.

kevin9foong and others added 3 commits November 12, 2024 21:27
… 8.14.0 in /shared (#7877)

* chore(deps-dev): bump @typescript-eslint/parser in /shared

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.12.2 to 8.14.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.14.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps-dev): bump @typescript-eslint/eslint-plugin in /shared

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 8.12.2 to 8.14.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.14.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: update eslint packages in all package-json

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ken <[email protected]>
@KenLSM KenLSM deleted the release_v6.160.0 branch November 13, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant