Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrf-admin-view): hawkeye v1.0 #7965

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from
Open

feat(mrf-admin-view): hawkeye v1.0 #7965

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
1c304c4
feat: add columns for mrf responses page
kevin9foong Dec 2, 2024
9f89d28
feat: fix default paddings for table
kevin9foong Dec 9, 2024
42ae99a
chore: update comment
kevin9foong Dec 9, 2024
c5c5cdc
feat: pipe step number to FE response table
kevin9foong Dec 9, 2024
b817a59
feat: log step meta and pipe to fe response table
kevin9foong Dec 9, 2024
f213752
fix: checking is form rejected error
kevin9foong Dec 9, 2024
6983771
feat: add status badges
kevin9foong Dec 9, 2024
3614690
feat: add csv download col
kevin9foong Dec 10, 2024
936c973
fix: add define global
kevin9foong Dec 10, 2024
009f840
feat: support cols in csv
kevin9foong Dec 11, 2024
c276fa4
fix: workflowStep being 0 is defined as falsy
kevin9foong Dec 11, 2024
d5f044e
feat: add approved rejected status in individualresponse
kevin9foong Dec 11, 2024
6a28c16
feat: map workflow status to business friendly status
kevin9foong Dec 11, 2024
8a8ddac
fix: change imports to relative
kevin9foong Dec 11, 2024
a8bdd88
fix: failing unit tests
kevin9foong Dec 13, 2024
609ccec
feat: add datetime validation for submittedAt
kevin9foong Dec 13, 2024
60d1654
fix: failing FE unit tests
kevin9foong Dec 13, 2024
86c46c2
feat: resize table cols for mrf to follow storage mode as much as pos…
kevin9foong Dec 13, 2024
177f2fd
feat: update copy for first step
kevin9foong Dec 13, 2024
75ac070
fix: bug where last col does not expand in scrollable
kevin9foong Dec 13, 2024
90eb8e5
feat: add tc for testing the metadata builder
kevin9foong Dec 13, 2024
2384693
feat: add tc for appending mrf meta to mrf submission stream
kevin9foong Dec 13, 2024
cd734b9
feat: add tc for submission.server.model to fetch mrf meta
kevin9foong Dec 13, 2024
3d80ac3
feat: add tc for csv generator for mrf
kevin9foong Dec 13, 2024
2139b9a
feat: fix tc missing required fields
kevin9foong Dec 13, 2024
c6eb27e
fix: bug where approved is marked as completed instead
kevin9foong Dec 13, 2024
90d375b
fix: submission.server.model tc
kevin9foong Dec 13, 2024
15f6d2f
fix: import ordering for lint
kevin9foong Dec 13, 2024
2b9ca5d
feat: add chromatic story for mrf dashboard
kevin9foong Dec 13, 2024
0ef1e49
chore: remove redundant comment
kevin9foong Dec 15, 2024
d3004bf
chore: add docs on rationale of destructuring array
kevin9foong Dec 23, 2024
9ecac23
chore: rename from non-mrf to base
kevin9foong Dec 23, 2024
1ac3620
chore: refactor code to remove usage of undefined in argument
kevin9foong Dec 23, 2024
66b411c
feat: make typing more explicit for case in getStatusFromWorkflowStatus
kevin9foong Dec 23, 2024
2b8d32d
fix: remove global access in decrypt and config in vite
kevin9foong Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...-form/responses/ResponsesPage/storage/UnlockedResponses/ResponsesTable/ResponsesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useCallback, useEffect, useMemo } from 'react'

Check failure on line 1 in frontend/src/features/admin-form/responses/ResponsesPage/storage/UnlockedResponses/ResponsesTable/ResponsesTable.tsx

View workflow job for this annotation

GitHub Actions / frontend_lint 

Run autofix to sort these imports!
import { BiCheckDouble, BiSolidHourglass } from 'react-icons/bi'
import { useNavigate } from 'react-router-dom'
import {
Expand Down Expand Up @@ -35,7 +35,7 @@
import { useUnlockedResponses } from '../UnlockedResponsesProvider'

import { getNetAmount } from './utils'
import { MRF_CURRENT_STEP_LABEL, MRF_STATUS_LABEL, MRF_FIRST_STEP_TIMESTAMP_LABEL } from '~features/admin-form/responses/constants'

Check failure on line 38 in frontend/src/features/admin-form/responses/ResponsesPage/storage/UnlockedResponses/ResponsesTable/ResponsesTable.tsx

View workflow job for this annotation

GitHub Actions / frontend_lint 

Replace `·MRF_CURRENT_STEP_LABEL,·MRF_STATUS_LABEL,·MRF_FIRST_STEP_TIMESTAMP_LABEL·` with `⏎··MRF_CURRENT_STEP_LABEL,⏎··MRF_STATUS_LABEL,⏎··MRF_FIRST_STEP_TIMESTAMP_LABEL,⏎`

type ResponseColumnData = SubmissionMetadata

Expand Down Expand Up @@ -82,6 +82,7 @@
Header: 'Timestamp',
accessor: 'submissionTime',
width: 250,
minWidth: 250,
disableResizing: true,
},
]
Expand Down Expand Up @@ -193,7 +194,8 @@
Header: MRF_FIRST_STEP_TIMESTAMP_LABEL,
accessor: 'submissionTime',
width: 250,
disableResizing: true
minWidth: 250,
Copy link
Contributor Author

@kevin9foong kevin9foong Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: re-using the same fix as existing storage mode responses table columns to include minWidth which allows the bar to expand for the rightmost column when the screen is small and horizontal scroll is enabled.

disableResizing: true,
},
]

Expand Down
Loading