Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.168.0 #7971

Merged
merged 5 commits into from
Dec 3, 2024
Merged

build: release v6.168.0 #7971

merged 5 commits into from
Dec 3, 2024

Conversation

kevin9foong
Copy link
Contributor

@kevin9foong kevin9foong commented Dec 3, 2024

New

  • fix: search fields drag and drop mismatch #7972
  • build: merge release v6.167.0 to develop #7964
  • feat: implement field search functionality #7958
  • feat(mrf be validation): enable mrf response validation hard block #7963
  • build: release v6.167.0 #7962

Dependencies

Dev-Dependencies

Tests

feat: implement field search functionality #7958

Search bar works and can drag and drop fields to create fields

  • Create a new form
  • Enter search term into field (should find exact match + hidden field matches)
  • Drag and drop to create field
  • Ensure field is created and form can be saved

fix: search fields drag and drop mismatch #7972

Left drawer create works

  • Filter and create a attachment field
  • Click on the Save field button.
  • Ensure the attachment field is created.

feat(mrf be validation): enable mrf response validation hard block #7963

TC1: Can submit MRF

  • Create multiple step MRF with a few fields with validation enabled (Eg, text field validating for exactly 5 characters)
  • Submit all steps of MRF
  • Assert it works and results are recorded

TC2: Invalid response is blocked

  • Copy the cURL request from TC1.
  • Change the response to include invalid responses.
  • Assert submission is blocked with the response message There is something wrong with your form submission. Please check your responses and try again. If the problem persists, please refresh the page.

…7963)

* feat: enable mrf response validation hard block

* feat: add route mapping for FieldValidationErrorV3
* feat: implement search functionality

* fix: change val to event

* fix: refactor FieldSearchBar to own component file

* feat: support search alias matching and refactor duplicate code

* feat: add more suggested search aliases
build: merge release v6.167.0 to develop
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 3, 2024

Datadog Report

Branch report: release_v6.168.0
Commit report: 49b9755
Test service: formsg

✅ 0 Failed, 995 Passed, 1 Skipped, 2m 42.36s Total duration (4m 12.35s time saved)

fix: maintain original index to match ordered field list when dropped
@kevin9foong kevin9foong merged commit 32916c4 into release-al2 Dec 3, 2024
47 of 48 checks passed
@kevin9foong kevin9foong deleted the release_v6.168.0 branch December 3, 2024 08:02
@KenLSM KenLSM mentioned this pull request Dec 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants