Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(myinfo-children): enable myinfo child on storage admin create page #7988

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Dec 11, 2024

Problem

Enable MyInfo children on Storage mode.

However, the data sent over through webhooks uses getMyInfoChildHashKey which contains the childname ie., _id: childrenbirthrecords.67585683e1ced6d790a91f53.childname.0.Janice Wong. This prevents downstream automation from reading data consistently as the field._id changes every submission.

Closes FRM-1921

Solution

Remove childname from _id after submission.

Breaking Changes

  • No - this PR is backwards compatible

@KenLSM KenLSM changed the title enable myinfo child on storage admin create page feat(myinfo-children): enable myinfo child on storage admin create page Dec 11, 2024
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 11, 2024

Datadog Report

Branch report: feat/child-storage
Commit report: 1156f7a
Test service: formsg

✅ 0 Failed, 995 Passed, 1 Skipped, 2m 45.98s Total duration (4m 0.52s time saved)

@KenLSM KenLSM requested a review from scottheng96 December 16, 2024 05:28
@KenLSM KenLSM merged commit 2184850 into develop Dec 16, 2024
22 checks passed
@KenLSM KenLSM deleted the feat/child-storage branch December 16, 2024 10:59
@KenLSM KenLSM mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants