Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only show fixed translations for supported forms #8038

Merged
merged 2 commits into from
Jan 12, 2025
Merged

fix: only show fixed translations for supported forms #8038

merged 2 commits into from
Jan 12, 2025
+11 −5

Conversation

siddarth2824
Copy link
Collaborator

Problem

  • The system currently uses a single local storage key to manage language settings across both the admin page and public forms. This shared configuration causes unintended language persistence. For example, when users select Chinese whilst viewing a multi-language form and subsequently navigate to the admin login page, they encounter Chinese translations. Additionally, this affects forms without multi-language support, where fixed translations inappropriately display in the previously selected language due to the persisted language setting in local storage.

Solution

  • Remove the Chinese translations used in login.
  • Default back to en-SG language for I18n if the form does not support multi-language feature.

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

@siddarth2824 siddarth2824 requested a review from KenLSM January 10, 2025 05:31
@KenLSM KenLSM merged commit 4863334 into develop Jan 12, 2025
24 of 26 checks passed
@KenLSM KenLSM deleted the fix/only-show-fixed-translations-for-supported-forms branch January 12, 2025 12:33
@KenLSM KenLSM mentioned this pull request Jan 12, 2025
Merged
3 tasks
KenLSM added a commit that referenced this pull request Jan 14, 2025
@KenLSM @dependabot
@mantariksh @siddarth2824 @kevin9foong
Merge pull request #8039 from opengovsg/release_v6.174.0
ea5f86f 
* fix(deps): bump libphonenumber-js from 1.11.16 to 1.11.17 in /shared (#8021)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.16 to 1.11.17.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.16...v1.11.17)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: mongoose, nanoid packages update (#8000)

* chore: update mongoose, dependabot #378

* chore: update react-email-preview/nanoid

* chore: update fe/be nanoid

* feat(iframe): add frame messaging for paysg (#7979)

* feat: update iframe parent on form submission

* fix: remove localhost from trusted origins

---------

Co-authored-by: Antariksh Mahajan <[email protected]>

* fix: only show fixed translations for supported forms (#8038)

* fix: default back to english language if form does not support multi-language

* fix: remove login translations from being fetched

* fix: set limit to 250kb for whitelist (#8043)

Co-authored-by: Ken <[email protected]>

* chore: bump version to v6.174.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Antariksh Mahajan <[email protected]>
Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
Co-authored-by: Kevin Foong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddarth2824 @KenLSM