Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: upgrade lock file to v2 #1877

Closed
wants to merge 6 commits into from
Closed

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented Jul 5, 2022

Just a test PR at the moment

had to upgrade express-joi-validator to resolve a npm install problem

react-vis is unmaintained and doesnt work with react 17 on npm v7

npm install still fails because react-typed's latest version 1.2.0 doesnt work with react 17. In order to use package lock v2, we might actually need to downgrade react, or find an alternative library that works with react 17.

update: we might be able to drop react-typed and use the underlying typed.js library directly. This comment could be useful reference, though it's outdated and needs some modifications to the options type declaration.

@yong-jie yong-jie changed the title ignore me, package lock test PR chore(deps): upgrade lock file to v2 Jul 5, 2022
@yong-jie yong-jie marked this pull request as draft July 5, 2022 16:20
@yong-jie yong-jie changed the title chore(deps): upgrade lock file to v2 testing: upgrade lock file to v2 Jul 5, 2022
@yong-jie yong-jie closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants