Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix link to ibm plex sans font #2341

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Aug 27, 2024

This PR fixes some build issues:

  1. npm run dev fails because the link to retrieve the IBM plex sans font is broken
  2. GitHub actions are failing because docker-compose no longer exists, see this discussion
    • Solution: replaced it with docker compose (without the dash)

Tests

  • Test on staging that QR code generation works (png + svg)

@halfwhole halfwhole force-pushed the build/ibm-plex-link branch from 57fdc36 to a959fc4 Compare August 27, 2024 10:30
@halfwhole halfwhole marked this pull request as ready for review September 3, 2024 07:09
Copy link
Contributor

@thanhdatle thanhdatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halfwhole halfwhole merged commit 02c9d3f into develop Sep 5, 2024
29 checks passed
@halfwhole halfwhole deleted the build/ibm-plex-link branch September 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants