Chore/add field styles for number input #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
reviewed
Dec 16, 2024
Comment on lines
58
to
61
| const mergedInputStyles = useMemo( | ||
| () => mergeThemeOverride(styles.field, inputStyles), | ||
| [inputStyles, styles.field], | ||
| ) |
There was a problem hiding this comment.
might not need to use mergeThemeOverride and just assign inputStyles directly to input's sx prop. Chakra UI has a priority list for styles (_css < sx). Can you try and see whether just using sx with inputStyles is enough?
There was a problem hiding this comment.
you're right, it works. Just updated
|
I'll run a release tomorrow morning. ping me if i forget @joyce-foo |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently NumberInput does not allow for overriding of inner input styles. Armoury needs to override the padding so that the number does not cut off
Solution
Allow merging of styles for inner input component in NumberInput
Local test
