test(s3): improve coverage

opengovsg · Mar 7, 2024 · f728413 · f728413
1 parent e24a81a
commit f728413
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/src/__tests__/s3.service.spec.ts b/src/__tests__/s3.service.spec.ts
@@ -177,6 +177,23 @@ describe('S3Service', () => {
         'Moved document in s3',
       )
     })
+
+    it('should throw on bad versionId from S3 client', async () => {
+      // Arrange
+      mockS3Send.mockReturnValue({ VersionId: undefined })
+      const mockS3Service = new S3Service(testConfig, mockLogger)
+
+      // Act and Assert
+      await expect(
+        mockS3Service.moveS3File({
+          sourceBucketName: 'sourceBucketName',
+          sourceObjectKey: 'sourceObjectKey',
+          sourceObjectVersionId: 'sourceObjectVersionId',
+          destinationBucketName: 'destinationBucketName',
+          destinationObjectKey: 'destinationObjectKey',
+        }),
+      ).rejects.toThrow(new Error('VersionId is empty'))
+    })
   })
   describe('getS3FileStreamWithVersionId', () => {
     it('should return file stream with version id', async () => {