-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLU-91: [SGID-LOGIN-5] **RFC** Enable multi-hat users to select email #206
Merged
ogp-weeloong
merged 5 commits into
feat/sgid/multi-hat/mutation
from
feat/sgid/multi-hat/selection
Sep 15, 2023
Merged
PLU-91: [SGID-LOGIN-5] **RFC** Enable multi-hat users to select email #206
ogp-weeloong
merged 5 commits into
feat/sgid/multi-hat/mutation
from
feat/sgid/multi-hat/selection
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selection # Conflicts: # packages/frontend/src/pages/SgidRedirect/index.tsx
* chore: refactor naming and update styles * PLU-91: [SGID-LOGIN-6] Set up per-env SGID client IDs (#214) --------- Co-authored-by: Kuan Wee Loong <[email protected]>
ogp-weeloong
added a commit
that referenced
this pull request
Sep 15, 2023
* feat: multi-hat mutation * PLU-91: [SGID-LOGIN-5] **RFC** Enable multi-hat users to select email (#206) * chore: refactor naming and update styles (#213) * PLU-91: [SGID-LOGIN-6] Set up per-env SGID client IDs (#214) --------- Co-authored-by: Kuan Wee Loong <[email protected]> Co-authored-by: Ian Chen <[email protected]>
ogp-weeloong
added a commit
that referenced
this pull request
Sep 15, 2023
* feat: sgid failure page * PLU-91: [SGID-LOGIN-4] Support multi-hat SGID users (#205) * PLU-91: [SGID-LOGIN-5] **RFC** Enable multi-hat users to select email (#206) * chore: refactor naming and update styles (#213) * PLU-91: [SGID-LOGIN-6] Set up per-env SGID client IDs (#214) --------- Co-authored-by: Kuan Wee Loong <[email protected]> Co-authored-by: Ian Chen <[email protected]>
ogp-weeloong
added a commit
that referenced
this pull request
Sep 15, 2023
* feat: add sgid login button * PLU-91: [SGID-LOGIN-3] Implement SGID failure modal (#204) * PLU-91: [SGID-LOGIN-4] Support multi-hat SGID users (#205) * PLU-91: [SGID-LOGIN-5] **RFC** Enable multi-hat users to select email (#206) * chore: refactor naming and update styles (#213) * PLU-91: [SGID-LOGIN-6] Set up per-env SGID client IDs (#214) --------- Co-authored-by: Kuan Wee Loong <[email protected]> Co-authored-by: Ian Chen <[email protected]>
ogp-weeloong
added a commit
that referenced
this pull request
Sep 15, 2023
* chore: add sgid sdk * feat: sgid login mutation * PLU-91: [SGID-LOGIN-2] Implement SGID login button (#203) * feat: add sgid login button * PLU-91: [SGID-LOGIN-3] Implement SGID failure modal (#204) * PLU-91: [SGID-LOGIN-4] Support multi-hat SGID users (#205) * PLU-91: [SGID-LOGIN-5] **RFC** Enable multi-hat users to select email (#206) * chore: refactor naming and update styles (#213) * PLU-91: [SGID-LOGIN-6] Set up per-env SGID client IDs (#214) --------- Co-authored-by: Kuan Wee Loong <[email protected]> Co-authored-by: Ian Chen <[email protected]>
ogp-weeloong
added a commit
that referenced
this pull request
Sep 19, 2023
* chore: add sgid sdk * feat: sgid login mutation * PLU-91: [SGID-LOGIN-2] Implement SGID login button (#203) * feat: add sgid login button * PLU-91: [SGID-LOGIN-3] Implement SGID failure modal (#204) * PLU-91: [SGID-LOGIN-4] Support multi-hat SGID users (#205) * PLU-91: [SGID-LOGIN-5] **RFC** Enable multi-hat users to select email (#206) * chore: refactor naming and update styles (#213) * PLU-91: [SGID-LOGIN-6] Set up per-env SGID client IDs (#214) --------- Co-authored-by: Kuan Wee Loong <[email protected]> Co-authored-by: Ian Chen <[email protected]> # Conflicts: # packages/frontend/src/theme/foundations/textStyles.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to support SGID login as an alternative to OTP.
Solution
As opposed to the usual SGID approach of creating routes on the back end, we will implement SGID using front end routes + GraphQL instead (to avoid us mixing and matching classic REST vs GraphQL where possible).
High Level Approach
See #202 for full details.
/login/sgid/redirect
, which processes auth data from SGID + renders work email list for selection.PR Notes
This PR enhances step 4 to enable multi-hatted users to select and login with a particular work email.
RFC Needed
UX inputs pls.
SCREENSHOTS

Tests
loginWithSgid
mutation, and check that I get redirected to this selection screen.