Refactor/remove phonebook (#2235)

* refactor: remove phonebook * chore: add unsubscriber count back to FE --------- Co-authored-by: KishenKumarrrrr <[email protected]>
opengovsg · Nov 23, 2023 · c5c3a1d · c5c3a1d
1 parent 2d2c7d8
commit c5c3a1d
Show file tree

Hide file tree

Showing 32 changed files with 40 additions and 1,289 deletions.
diff --git a/.secrets.baseline b/.secrets.baseline
@@ -345,7 +345,7 @@
         "filename": "frontend/src/test-utils/api/index.ts",
         "hashed_secret": "2e7a7ee14caebf378fc32d6cf6f557f347c96773",
         "is_verified": false,
-        "line_number": 46
+        "line_number": 44
       }
     ],
     "worker/.env-example": [
@@ -365,5 +365,5 @@
       }
     ]
   },
-  "generated_at": "2023-09-25T09:48:43Z"
+  "generated_at": "2023-11-16T03:18:03Z"
 }
diff --git a/backend/src/core/config.ts b/backend/src/core/config.ts
@@ -174,10 +174,6 @@ interface ConfigSchema {
   flamingo: {
     dbUri: string
   }
-  phonebook: {
-    endpointUrl: string
-    apiKey: string
-  }
   sgid: {
     clientId: string
     clientSecret: string
@@ -811,20 +807,6 @@ const config: Config<ConfigSchema> = convict({
       env: 'FLAMINGO_DB_URI',
     },
   },
-  phonebook: {
-    endpointUrl: {
-      doc: 'Endpoint url of phonebook server',
-      default: 'http://localhost:8080',
-      env: 'PHONEBOOK_URL',
-      format: 'required-string',
-    },
-    apiKey: {
-      doc: 'API key to make requests to Phonebook',
-      default: 'API_KEY',
-      env: 'PHONEBOOK_API_KEY',
-      format: 'required-string',
-    },
-  },
   sgid: {
     clientId: {
       doc: 'Client ID of application registered with sgID',

diff --git a/backend/src/core/middlewares/index.ts b/backend/src/core/middlewares/index.ts
@@ -8,4 +8,3 @@ export * from './protected.middleware'
 export * from './unsubscriber.middleware'
 export * from './file-attachment.middleware'
 export * as ExperimentMiddleware from './experiment.middleware'
-export * from './phonebook.middleware'
diff --git a/backend/src/core/middlewares/phonebook.middleware.ts b/backend/src/core/middlewares/phonebook.middleware.ts
diff --git a/backend/src/core/models/index.ts b/backend/src/core/models/index.ts
@@ -13,4 +13,3 @@ export * from './unsubscriber'
 export * from './agency'
 export * from './domain'
 export * from './initialize-models'
-export * from './managed-list-campaign'
diff --git a/backend/src/core/models/initialize-models.ts b/backend/src/core/models/initialize-models.ts
@@ -6,7 +6,6 @@ import {
   Credential,
   Domain,
   JobQueue,
-  ManagedListCampaign,
   ProtectedMessage,
   Statistic,
   Unsubscriber,
@@ -95,14 +94,12 @@ export const initializeModels = (sequelize: Sequelize): void => {
     CampaignGovsgTemplate,
     GovsgVerification,
   ]
-  const phonebookModels = [ManagedListCampaign]
   sequelize.addModels([
     ...coreModels,
     ...emailModels,
     ...smsModels,
     ...telegramModels,
     ...govsgModels,
-    ...phonebookModels,
   ])
 }
 

diff --git a/backend/src/core/models/managed-list-campaign.ts b/backend/src/core/models/managed-list-campaign.ts
diff --git a/backend/src/core/routes/index.ts b/backend/src/core/routes/index.ts
@@ -53,7 +53,6 @@ import {
   InitGovsgMessageTransactionalRoute,
 } from '@govsg/routes'
 import { InitGovsgTransactionalMiddleware } from '@govsg/middlewares/govsg-transactional.middleware'
-import phonebookRoutes from '@core/routes/phonebook.routes'
 
 export const InitV1Route = (app: Application): Router => {
   const logger = loggerWithLabel(module)
@@ -286,12 +285,6 @@ export const InitV1Route = (app: Application): Router => {
 
   router.use('/callback/govsg', govsgCallbackRoutes)
 
-  router.use(
-    '/phonebook',
-    authMiddleware.getAuthMiddleware([AuthType.Cookie]),
-    phonebookRoutes
-  )
-
   router.use(
     '/api-key',
     authMiddleware.getAuthMiddleware([AuthType.Cookie]),

diff --git a/backend/src/core/routes/phonebook.routes.ts b/backend/src/core/routes/phonebook.routes.ts
diff --git a/backend/src/core/services/phonebook.service.ts b/backend/src/core/services/phonebook.service.ts