Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor CI workflow and update test scripts #314

Merged
merged 11 commits into from
Sep 4, 2024
Merged

ci: refactor CI workflow and update test scripts #314

merged 11 commits into from
Sep 4, 2024

Conversation

karrui
Copy link
Collaborator

@karrui karrui commented Sep 3, 2024

TL;DR

Updated CI workflows, test scripts, and environment configurations to improve the development and testing process.

What changed?

  • Added a new reusable GitHub Action for setup and installation
  • Created a new comprehensive CI workflow (ci.yml) replacing the old main.yml
  • Updated the Chromatic workflow for visual regression testing
  • Modified test scripts in package.json for better organization and clarity
  • Updated the .env.test file to use quotes for the DATABASE_URL
  • Updated the load test README with the correct build command

How to test?

  1. Review the new CI workflow in .github/workflows/ci.yml
  2. Run the updated test scripts locally:
    • npm run test:vitest for unit and integration tests
    • npm run test:e2e for end-to-end tests
  3. Verify that the Chromatic workflow runs correctly on pull requests
  4. Check that the load test build command works: npm run load-test:build

Why make this change?

These changes aim to:

  • Streamline the CI process with a more comprehensive and organized workflow
  • Improve test script naming and execution for better developer experience
  • Ensure consistent setup across different GitHub Actions
  • Enhance the reliability and efficiency of the testing and deployment pipeline

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starter-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 4:50am

Copy link
Collaborator Author

karrui commented Sep 3, 2024

@karrui karrui changed the title ci: update ci.yml to separate unit and e2e tests feat: refactor CI workflow and update test scripts Sep 3, 2024
@karrui karrui marked this pull request as ready for review September 3, 2024 05:19
@karrui karrui requested a review from dextertanyj September 3, 2024 05:21
@karrui karrui changed the title feat: refactor CI workflow and update test scripts ci: refactor CI workflow and update test scripts Sep 3, 2024
Copy link
Collaborator Author

karrui commented Sep 4, 2024

Merge activity

  • Sep 4, 12:46 AM EDT: @karrui started a stack merge that includes this pull request via Graphite.
  • Sep 4, 12:48 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 4, 12:49 AM EDT: @karrui merged this pull request with Graphite.

@karrui karrui changed the base branch from update-integration-testing-suite to graphite-base/314 September 4, 2024 04:46
@karrui karrui changed the base branch from graphite-base/314 to main September 4, 2024 04:46
@karrui karrui merged commit b8d2e75 into main Sep 4, 2024
10 of 11 checks passed
@karrui karrui deleted the update-ci branch September 4, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant