Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After sgid login, the user is prompted to select a profile.
Whichever profile is selected, the email is sent to the server to be used as the primary identifier.
There is a validation step which checks that the email used is in one of the sgid profiles belonging to the user.
However, there is no case normalization performed on the sgid profile emails during this check.
Therefore, there could be a situation where the sgid profile emails are not lowercased, leading to an error when the user selects the profile.
Approach
Normalize the
work_email
when checking if the user selected email is equal to it.Additionally, the check for whether sgid login is enabled has been made consistent.